Extract ASGI scope creation into function#162
Conversation
|
Thanks for the PR @emcpow2. There is an issue here related to custom scope resolution that should also be considered when making a change like this, and I think if we decide to go with non-AWS event handling that will take some additional design consideration later as well. I'm going to close this because there is some investigation to do before we start extracting logic from the main adapter method. |
|
Thit PR does not introduce any complexity regarding the path resolution issue. Instead, the code looks cleaner and easier to test and to introduce new changes. Please consider reopening the PR. |
|
@emcpow2 I don't disagree with your approach generally, and I've actually thought we should do something like this for awhile now. However, I've held off on these kind of changes because once we introduce new public API then users will start relying on it in ways that conflict with other things we might want to do. This is the same reason I left the linked issue open because the design needs careful consideration. |
|
@emcpow2 I've taken the time to think about this some more - let's go ahead with it. I'll reopen and do a small review of some adjustments, but otherwise this should be fine to do now. Thanks. |
jordaneremieff
left a comment
jordaneremieff
left a comment
There was a problem hiding this comment.
Just a few small things then I think this will be good to merge. The most significant change request is to remove the separate method for handling the initial body (we can look at this as a separate issue later).
ediskandarov-cur
force-pushed
the
extract-asgi-scope-creation-into-func
branch
from
b0c8bc4 to
16371fa
Compare
extract scope and request body creation into a dedicated functions
ediskandarov-cur
force-pushed
the
extract-asgi-scope-creation-into-func
branch
2 times, most recently
from
a5b55de to
191b478
Compare
ediskandarov-cur
force-pushed
the
extract-asgi-scope-creation-into-func
branch
from
191b478 to
5c77151
Compare
ediskandarov-cur
changed the title
|
thanks. Done |
|
Looks good, thanks! |
* 🏗 simplify magnum call function extract scope and request body creation into a dedicated functions * 📝 add documentation to create scope function
* 🏗 simplify magnum call function extract scope and request body creation into a dedicated functions * 📝 add documentation to create scope function
* 🏗 simplify magnum call function extract scope and request body creation into a dedicated functions * 📝 add documentation to create scope function
2 participants
This is a required abstraction to create non-AWS event handlers.